From 4e83675bf80b0b134ef4035acce747722e9def73 Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Mon, 12 Feb 2024 17:38:56 -0500 Subject: rewriter: remove never-used default None when parsing arguments The add_arguments function is always called with a formatter in mesonmain.py, and if it were not, then it would be incorrect when calling argparse itself -- because formatter_class cannot be None, and defaults to its own builtin one. This violates None-safety. --- mesonbuild/rewriter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mesonbuild/rewriter.py b/mesonbuild/rewriter.py index 626551014..680eed1f8 100644 --- a/mesonbuild/rewriter.py +++ b/mesonbuild/rewriter.py @@ -25,7 +25,7 @@ class RewriterException(MesonException): # Note: when adding arguments, please also add them to the completion # scripts in $MESONSRC/data/shell-completions/ -def add_arguments(parser, formatter=None): +def add_arguments(parser, formatter): parser.add_argument('-s', '--sourcedir', type=str, default='.', metavar='SRCDIR', help='Path to source directory.') parser.add_argument('-V', '--verbose', action='store_true', default=False, help='Enable verbose output') parser.add_argument('-S', '--skip-errors', dest='skip', action='store_true', default=False, help='Skip errors instead of aborting') -- cgit v1.2.3