From 4f0452b2835c19dfd7b6ada2f6eb54c48ef8e564 Mon Sep 17 00:00:00 2001 From: Luke Elliott Date: Sun, 10 Jan 2021 15:54:20 +0000 Subject: fix: don't set FavorSizeOrSpeed in vs backend if optimization disabled (/Od set). Debugging is broken with clang-cl when FavorSizeOrSpeed is set. --- mesonbuild/backend/vs2010backend.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mesonbuild/backend/vs2010backend.py b/mesonbuild/backend/vs2010backend.py index e747dfa7d..98d69e768 100644 --- a/mesonbuild/backend/vs2010backend.py +++ b/mesonbuild/backend/vs2010backend.py @@ -1159,7 +1159,8 @@ class Vs2010Backend(backends.Backend): # Size-preserving flags if '/Os' in o_flags: ET.SubElement(clconf, 'FavorSizeOrSpeed').text = 'Size' - else: + # Note: setting FavorSizeOrSpeed with clang-cl conflicts with /Od and can make debugging difficult, so don't. + elif '/Od' not in o_flags: ET.SubElement(clconf, 'FavorSizeOrSpeed').text = 'Speed' # Note: SuppressStartupBanner is /NOLOGO and is 'true' by default self.generate_lang_standard_info(file_args, clconf) -- cgit v1.2.3