From 9f8df3529fa9026134d8fc01ab6daa21f36dcfbf Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Thu, 30 Dec 2021 14:58:57 -0500 Subject: rename lint workflow for less confusion For a long time now, this has done 3 different things, only one of which is mypy. But they are labeled: - LintMypy / lint (runs pylint) - LintMypy / custom_lint (runs a custom script) - LintMypy / mypy (actually runs mypy) This reduces the usable length of the label which isn't all that long to begin with, is actively misleading, and even when you know what is going on, it becomes harder to tell at a glance what failed. Change it to be more unambiguous. --- .github/workflows/lint.yml | 46 +++++++++++++++++++++++++++++++++++++++++ .github/workflows/lint_mypy.yml | 46 ----------------------------------------- 2 files changed, 46 insertions(+), 46 deletions(-) create mode 100644 .github/workflows/lint.yml delete mode 100644 .github/workflows/lint_mypy.yml diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml new file mode 100644 index 000000000..cdfed113d --- /dev/null +++ b/.github/workflows/lint.yml @@ -0,0 +1,46 @@ +name: Lint + +concurrency: + group: lint-${{ github.head_ref }} + cancel-in-progress: true + +on: + push: + paths: + - "**.py" + - ".github/workflows/lint.yml" + pull_request: + paths: + - "**.py" + - ".github/workflows/lint.yml" + +jobs: + + pylint: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: actions/setup-python@v2 + with: + python-version: '3.x' + - run: python -m pip install pylint + - run: pylint mesonbuild + + custom_lint: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: actions/setup-python@v2 + with: + python-version: '3.x' + - run: python ./run_custom_lint.py + + mypy: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: actions/setup-python@v2 + with: + python-version: '3.x' + - run: python -m pip install mypy + - run: python run_mypy.py diff --git a/.github/workflows/lint_mypy.yml b/.github/workflows/lint_mypy.yml deleted file mode 100644 index 957270773..000000000 --- a/.github/workflows/lint_mypy.yml +++ /dev/null @@ -1,46 +0,0 @@ -name: LintMypy - -concurrency: - group: mypy-${{ github.head_ref }} - cancel-in-progress: true - -on: - push: - paths: - - "**.py" - - ".github/workflows/lint_mypy.yml" - pull_request: - paths: - - "**.py" - - ".github/workflows/lint_mypy.yml" - -jobs: - - lint: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v2 - with: - python-version: '3.x' - - run: python -m pip install pylint - - run: pylint mesonbuild - - custom_lint: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v2 - with: - python-version: '3.x' - - run: python ./run_custom_lint.py - - mypy: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v2 - with: - python-version: '3.x' - - run: python -m pip install mypy - - run: python run_mypy.py -- cgit v1.2.3