From dfd8cfbd8d9ce03473cb17a722400cb4a8d1b67e Mon Sep 17 00:00:00 2001 From: Tamás Bálint Misius Date: Sat, 4 Nov 2023 12:59:01 +0100 Subject: vs2010backend: fix incompatibility with custom manifests EmbedManifest seems to default to true, which creates a default manifest based on other parameters (likewise defaults) and makes it impossible to supply your own with CREATEPROCESS_MANIFEST_RESOURCE_ID. There is value to being able to do this and no value to the default one, so this should be disabled. --- mesonbuild/backend/vs2010backend.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mesonbuild/backend/vs2010backend.py b/mesonbuild/backend/vs2010backend.py index cb1ea7833..f4de65823 100644 --- a/mesonbuild/backend/vs2010backend.py +++ b/mesonbuild/backend/vs2010backend.py @@ -693,6 +693,8 @@ class Vs2010Backend(backends.Backend): if target_ext: ET.SubElement(direlem, 'TargetExt').text = target_ext + ET.SubElement(direlem, 'EmbedManifest').text = 'false' + return (root, type_config) def gen_run_target_vcxproj(self, target: build.RunTarget, ofname: str, guid: str) -> None: -- cgit v1.2.3