From fd892ad7cec12a34287f65a57c44703a6f4e4119 Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Wed, 8 Jan 2020 13:23:52 -0800 Subject: dependencies: Make Dependency initializer signatures match Currently PkgConfig takes language as a keyword parameter in position 3, while the others take it as positional in position 2. Because most dependencies don't actually set a language (they use C style linking), using a positional argument makes more sense. ExtraFrameworkDependencies is even more different, and duplicates some arguments from the base ExternalDependency class. For later changes I'm planning to make having all of the dependencies use the same signature is really, really helpful. --- mesonbuild/modules/python.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mesonbuild/modules/python.py') diff --git a/mesonbuild/modules/python.py b/mesonbuild/modules/python.py index 1e2b2ee95..6644fd27c 100644 --- a/mesonbuild/modules/python.py +++ b/mesonbuild/modules/python.py @@ -44,7 +44,7 @@ mod_kwargs -= set(['name_prefix', 'name_suffix']) class PythonDependency(ExternalDependency): def __init__(self, python_holder, environment, kwargs): - super().__init__('python', environment, None, kwargs) + super().__init__('python', environment, kwargs) self.name = 'python' self.static = kwargs.get('static', False) self.embed = kwargs.get('embed', False) -- cgit v1.2.3