From 00bfbcbfa2a5c59f790962b3b1f7e1088fe08947 Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Sun, 15 Aug 2021 02:19:13 -0400 Subject: tests: make detecting broken compilers always run without tracebacks Fixes regression in commit 75688240cfca7eed08c2754daa784c9bd1a70a73. Even though this function is *currently* only invoked on Windows, these environment variables may not actually exist -- and apparently don't in at least the "UnusedMissingReturn / windows" test run, which... did not get triggered by that commit, since it only edited the testsuite runner, not any test cases. \o/ --- run_project_tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'run_project_tests.py') diff --git a/run_project_tests.py b/run_project_tests.py index cc19568a3..7896ee591 100755 --- a/run_project_tests.py +++ b/run_project_tests.py @@ -1008,7 +1008,7 @@ def has_broken_rustc() -> bool: def has_broken_compiler_combination() -> bool: # Rust and vs2017 do not work together. But only with 32 bits. - if os.environ['VisualStudioVersion'] == '15.0' and os.environ['Platform'] == 'x86': + if os.environ.get('VisualStudioVersion') == '15.0' and os.environ.get('Platform') == 'x86': return True # Clang-cl also fails with Rust. if shutil.which('cl') is None and shutil.which('clang-cl'): -- cgit v1.2.3