diff options
| author | Eli Schwartz <eschwartz93@gmail.com> | 2023-12-05 20:33:38 -0500 |
|---|---|---|
| committer | Eli Schwartz <eschwartz93@gmail.com> | 2023-12-10 19:02:39 -0500 |
| commit | 17c6d5eb478386ad183fa7e11b688217645d8f4f (patch) | |
| tree | 9665d76103b8b9405b4aeb65e174a60a368533d7 /.github/workflows/msys2.yml | |
| parent | 5883089f6c7b39726dd06a48a23d8eb8754a75f7 (diff) | |
| download | meson-17c6d5eb478386ad183fa7e11b688217645d8f4f.tar.gz | |
unittests: migrate from jsonschema to fastjsonschema
The former has rust dependencies, which lead to max capping on Cygwin
since there is no rust compiler there. But it turns out there are other
disadvantages of jsonschema:
- it involves installing 5 wheels, instead of just 1
- it is much slower
To give some perspective to the latter issue, this is what it looks like
when I test with jsonschema:
```
===== 1 passed, 509 deselected in 3.07s =====
Total time: 3.341 seconds
```
And here's what it looks like when I test with fastjsonschema:
```
===== 1 passed, 509 deselected, 1 warning in 0.28s =====
Total time: 0.550 seconds
```
I cannot think of a good reason to use the former. Although in order to
work on old CI images, we'll support it as a fallback mechanism
Diffstat (limited to '.github/workflows/msys2.yml')
| -rw-r--r-- | .github/workflows/msys2.yml | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/.github/workflows/msys2.yml b/.github/workflows/msys2.yml index 2bdcdd30e..043f5ce2a 100644 --- a/.github/workflows/msys2.yml +++ b/.github/workflows/msys2.yml @@ -80,7 +80,7 @@ jobs: mingw-w64-${{ matrix.MSYS2_ARCH }}-python-lxml mingw-w64-${{ matrix.MSYS2_ARCH }}-python-setuptools mingw-w64-${{ matrix.MSYS2_ARCH }}-python-pip - mingw-w64-${{ matrix.MSYS2_ARCH }}-python-jsonschema + mingw-w64-${{ matrix.MSYS2_ARCH }}-python-fastjsonschema mingw-w64-${{ matrix.MSYS2_ARCH }}-${{ matrix.TOOLCHAIN }} - name: Install dependencies @@ -100,7 +100,7 @@ jobs: - name: Run Tests run: | if [[ "${{ matrix.MSYS2_ARCH }}" == "x86_64" ]]; then - # There apparently is no clean way to add to the PATH in the + # There apparently is no clean way to add to the PATH in the # previous step? # See for instance https://github.com/msys2/setup-msys2/issues/171 export PATH=$PATH:$PWD/pypy3local |
