summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEli Schwartz <eschwartz93@gmail.com>2025-09-25 15:08:02 -0400
committerDylan Baker <dylan@pnwbakers.com>2025-09-25 13:34:11 -0700
commit6f0067507e59ad87303c0d5db12bca058dcb5f2c (patch)
tree924838452a9a5703650b6bb30097ec553055c30a
parentd57d06e29c45a7475a50e31816f1969e884e6d3a (diff)
downloadmeson-6f0067507e59ad87303c0d5db12bca058dcb5f2c.tar.gz
backends: in "god function" to generate targets, early return after delegated func
We would return in a handful of lines when we check for a guaranteed-true statement, `if name in self.processed_targets:` But explicitly returning here lets mypy type narrow on the isinstance checks.
-rw-r--r--mesonbuild/backend/ninjabackend.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/mesonbuild/backend/ninjabackend.py b/mesonbuild/backend/ninjabackend.py
index a095b7652..072789541 100644
--- a/mesonbuild/backend/ninjabackend.py
+++ b/mesonbuild/backend/ninjabackend.py
@@ -876,8 +876,10 @@ class NinjaBackend(backends.Backend):
os.makedirs(self.get_target_private_dir_abs(target), exist_ok=True)
if isinstance(target, build.CustomTarget):
self.generate_custom_target(target)
+ return
if isinstance(target, build.RunTarget):
self.generate_run_target(target)
+ return
compiled_sources: T.List[str] = []
source2object: T.Dict[str, str] = {}
name = target.get_id()