diff options
| author | Daniel Mensinger <daniel@mensinger-ka.de> | 2019-12-04 17:29:51 +0100 |
|---|---|---|
| committer | Jussi Pakkanen <jpakkane@gmail.com> | 2019-12-05 00:22:10 +0200 |
| commit | b5cec1c632c4639875ef97cefa98ae30521212d0 (patch) | |
| tree | 85fda8e5e27bd0d874e3fe9ab0ead789fc2bc475 | |
| parent | 0c875e16c4f79cad5440304ea89d44c9d600b6f0 (diff) | |
| download | meson-b5cec1c632c4639875ef97cefa98ae30521212d0.tar.gz | |
lgtm: ignore all safe `__init__ method calls overridden method` warnings
| -rw-r--r-- | mesonbuild/dependencies/base.py | 4 | ||||
| -rw-r--r-- | mesonbuild/rewriter.py | 4 |
2 files changed, 5 insertions, 3 deletions
diff --git a/mesonbuild/dependencies/base.py b/mesonbuild/dependencies/base.py index 36d9f6574..8fc198290 100644 --- a/mesonbuild/dependencies/base.py +++ b/mesonbuild/dependencies/base.py @@ -1714,7 +1714,9 @@ class ExternalProgram: break if not silent: - if self.found(): + # ignore the warning because derived classes never call this __init__ + # method, and thus only the found() method of this class is ever executed + if self.found(): # lgtm [py/init-calls-subclass] mlog.log('Program', mlog.bold(name), 'found:', mlog.green('YES'), '(%s)' % ' '.join(self.command)) else: diff --git a/mesonbuild/rewriter.py b/mesonbuild/rewriter.py index 3712c075f..5078d3c73 100644 --- a/mesonbuild/rewriter.py +++ b/mesonbuild/rewriter.py @@ -103,11 +103,11 @@ class RequiredKeys: class MTypeBase: def __init__(self, node: Optional[BaseNode] = None): if node is None: - self.node = self._new_node() + self.node = self._new_node() # lgtm [py/init-calls-subclass] (node creation does not depend on base class state) else: self.node = node self.node_type = None - for i in self.supported_nodes(): + for i in self.supported_nodes(): # lgtm [py/init-calls-subclass] (listing nodes does not depend on base class state) if isinstance(self.node, i): self.node_type = i |