summaryrefslogtreecommitdiff
path: root/ci
diff options
context:
space:
mode:
authorEli Schwartz <eschwartz93@gmail.com>2023-12-05 20:33:38 -0500
committerEli Schwartz <eschwartz93@gmail.com>2023-12-10 19:02:39 -0500
commit17c6d5eb478386ad183fa7e11b688217645d8f4f (patch)
tree9665d76103b8b9405b4aeb65e174a60a368533d7 /ci
parent5883089f6c7b39726dd06a48a23d8eb8754a75f7 (diff)
downloadmeson-17c6d5eb478386ad183fa7e11b688217645d8f4f.tar.gz
unittests: migrate from jsonschema to fastjsonschema
The former has rust dependencies, which lead to max capping on Cygwin since there is no rust compiler there. But it turns out there are other disadvantages of jsonschema: - it involves installing 5 wheels, instead of just 1 - it is much slower To give some perspective to the latter issue, this is what it looks like when I test with jsonschema: ``` ===== 1 passed, 509 deselected in 3.07s ===== Total time: 3.341 seconds ``` And here's what it looks like when I test with fastjsonschema: ``` ===== 1 passed, 509 deselected, 1 warning in 0.28s ===== Total time: 0.550 seconds ``` I cannot think of a good reason to use the former. Although in order to work on old CI images, we'll support it as a fallback mechanism
Diffstat (limited to 'ci')
-rw-r--r--ci/ciimage/common.sh2
-rw-r--r--ci/run.ps12
2 files changed, 2 insertions, 2 deletions
diff --git a/ci/ciimage/common.sh b/ci/ciimage/common.sh
index 67d59978f..016918240 100644
--- a/ci/ciimage/common.sh
+++ b/ci/ciimage/common.sh
@@ -15,7 +15,7 @@ base_python_pkgs=(
pytest-xdist
pytest-subtests
coverage
- jsonschema
+ fastjsonschema
)
python_pkgs=(
diff --git a/ci/run.ps1 b/ci/run.ps1
index badb4a74e..05bb6b69e 100644
--- a/ci/run.ps1
+++ b/ci/run.ps1
@@ -92,7 +92,7 @@ python --version
# Needed for running unit tests in parallel.
echo ""
-python -m pip --disable-pip-version-check install --upgrade pefile pytest-xdist pytest-subtests jsonschema coverage
+python -m pip --disable-pip-version-check install --upgrade pefile pytest-xdist pytest-subtests fastjsonschema coverage
# Needed for running the Cython tests
python -m pip --disable-pip-version-check install cython