diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2025-07-09 11:07:35 +0200 |
|---|---|---|
| committer | Dylan Baker <dylan@pnwbakers.com> | 2025-07-10 09:47:49 -0700 |
| commit | 1c14c08aabfd4852451d194a6f5aee9568fe4455 (patch) | |
| tree | 69e3d3b1697ef1c96663bfc28b3a8d1d4c887ca5 /docs/genrelnotes.py | |
| parent | 5736120edc2322476a01622b1e5106877f08d327 (diff) | |
| download | meson-1c14c08aabfd4852451d194a6f5aee9568fe4455.tar.gz | |
options: apply CFLAGS even if c_link_args exists
This restores the behavior before 1.8's option store refactoring.
The bug arises because c_link_args has been stored in pending_options,
and therefore the extended value (which get_global_options correctly
computes) is overwritten by the value passed on the command line.
In fact, this bug is the reason why I added the "link_args_from_envvar"
check: the CFLAGS would be ignored anyway, so I put that logic in code
instead of relying on the option store's behavior.
The fix is to extend the value *after* the option has been added and
the pending_options resolved. This requires a tiny refactoring of
the split between CoreData.add_lang_args and compilers.get_global_options.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'docs/genrelnotes.py')
0 files changed, 0 insertions, 0 deletions