summaryrefslogtreecommitdiff
path: root/docs/jsonvalidator.py
diff options
context:
space:
mode:
authorEli Schwartz <eschwartz93@gmail.com>2023-12-26 15:06:12 -0500
committerEli Schwartz <eschwartz93@gmail.com>2023-12-26 18:09:34 -0500
commit2fbc7b5ce3aced483b196dd10ca9eee1713b7494 (patch)
treee03ea0cd9e83680615c6636765e5b35775f63108 /docs/jsonvalidator.py
parent5ff60499453a390465aac2c60dd743d2c6964797 (diff)
downloadmeson-2fbc7b5ce3aced483b196dd10ca9eee1713b7494.tar.gz
Revert "clike: Deduplicate rpath linker flags"
This reverts commit 53ea59ad8455277797117d225f326851fe7d369c. This breaks at least: - frameworks/17 mpi - frameworks/30 scalapack The problem is that openmpi's pkg-config emitted link arguments includes: ``` -Wl,-rpath -Wl,/path/to/libdir ``` The deduplication logic in meson doesn't contain sufficient information to tell when the compiler is passing an argument that requires values, and definitely cannot tell when that argument is split across argv. But for arguments that *can* do this, it is not possible to deduplicate a single argument as standalone, because it is not standalone. The argument for deduplicating rpath here was that if you have multiple dependencies that all add the same rpath, the Apple ld64 emits a non-fatal warning "duplicate -rpath ignored". Since this is non-fatal, it's not a major issue. A major issue is when builds fatally error out with: ``` FAILED: scalapack_c cc -o scalapack_c scalapack_c.p/main.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,--start-group /usr/lib64/libscalapack.so /usr/lib64/liblapack.so /usr/lib64/libblas.so -Wl,-rpath -Wl,/usr/lib64 -Wl,/usr/lib64 -Wl,--enable-new-dtags /usr/lib64/libmpi.so -Wl,--end-group /usr/libexec/gcc/x86_64-pc-linux-gnu/ld: error: /usr/lib64: read: Is a directory ```
Diffstat (limited to 'docs/jsonvalidator.py')
0 files changed, 0 insertions, 0 deletions