diff options
| author | Eli Schwartz <eschwartz@archlinux.org> | 2023-07-17 23:02:56 -0400 |
|---|---|---|
| committer | Xavier Claessens <xclaesse@gmail.com> | 2023-10-20 18:07:05 -0400 |
| commit | 34ac2e4af6e5b4c86e8fcfef86042621d55dd141 (patch) | |
| tree | e06e84cb458677bed98885b85ce863d4308c41a4 /mesonbuild/compilers/compilers.py | |
| parent | 1cf0ed0997de355d15d9418448423ecf06a62467 (diff) | |
| download | meson-34ac2e4af6e5b4c86e8fcfef86042621d55dd141.tar.gz | |
fix ninja backend rules containing internal enum reprs
Partially reverts commit 1624354f33bf0a33f0e715ba1ca391ae0154ad19 which
moved a bunch of stuff from strings to enums. The issue here is that
Compiler.mode is not just, or primarily, something we compare, but is
instead written in as e.g. `rule c_{compiler.mode}` to build.ninja, so
this identifier needs to be a string.
Ultimately, the issue is that the commit tried to rewrite a bunch of
things called "mode" that had a couple of TODOs saying to use enums...
but it rewrote everything called "mode" regardless of whether it was a
function kwarg or a compiler property, even though the TODO only applied
to one of them.
Diffstat (limited to 'mesonbuild/compilers/compilers.py')
| -rw-r--r-- | mesonbuild/compilers/compilers.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mesonbuild/compilers/compilers.py b/mesonbuild/compilers/compilers.py index abf4ef430..fb399b114 100644 --- a/mesonbuild/compilers/compilers.py +++ b/mesonbuild/compilers/compilers.py @@ -527,7 +527,7 @@ class Compiler(HoldableObject, metaclass=abc.ABCMeta): language: str id: str warn_args: T.Dict[str, T.List[str]] - mode = CompileCheckMode.COMPILE + mode = 'COMPILER' def __init__(self, ccache: T.List[str], exelist: T.List[str], version: str, for_machine: MachineChoice, info: 'MachineInfo', |