diff options
| author | Dylan Baker <dylan@pnwbakers.com> | 2024-12-10 08:46:06 -0800 |
|---|---|---|
| committer | Dylan Baker <dylan@pnwbakers.com> | 2025-01-28 10:23:32 -0800 |
| commit | a47e8f260a7d179462abf7ef607472de44f2f0c5 (patch) | |
| tree | 6deef8d23233532876b77970ad83328a35cb1e66 /mesonbuild/dependencies | |
| parent | cdbd33a4f592166761e02a2054cecdadaacbef60 (diff) | |
| download | meson-a47e8f260a7d179462abf7ef607472de44f2f0c5.tar.gz | |
dependencies: correctly handle a language of None
For whatever reason Meson has always used None == <C Language>. This
doesn't make a lot of sense to me, but it's how things currently work,
and our dependency factories should handle that correctly.
Diffstat (limited to 'mesonbuild/dependencies')
| -rw-r--r-- | mesonbuild/dependencies/misc.py | 4 | ||||
| -rw-r--r-- | mesonbuild/dependencies/mpi.py | 4 |
2 files changed, 6 insertions, 2 deletions
diff --git a/mesonbuild/dependencies/misc.py b/mesonbuild/dependencies/misc.py index 7bfe198e0..8fdf619f0 100644 --- a/mesonbuild/dependencies/misc.py +++ b/mesonbuild/dependencies/misc.py @@ -29,7 +29,9 @@ def netcdf_factory(env: 'Environment', for_machine: 'mesonlib.MachineChoice', kwargs: T.Dict[str, T.Any], methods: T.List[DependencyMethods]) -> T.List['DependencyGenerator']: - language = kwargs.get('language', 'c') + language = kwargs.get('language') + if language is None: + language = 'c' if language not in ('c', 'cpp', 'fortran'): raise DependencyException(f'Language {language} is not supported with NetCDF.') diff --git a/mesonbuild/dependencies/mpi.py b/mesonbuild/dependencies/mpi.py index 2d9e992f6..a259972b0 100644 --- a/mesonbuild/dependencies/mpi.py +++ b/mesonbuild/dependencies/mpi.py @@ -27,7 +27,9 @@ def mpi_factory(env: 'Environment', for_machine: 'MachineChoice', kwargs: T.Dict[str, T.Any], methods: T.List[DependencyMethods]) -> T.List['DependencyGenerator']: - language = kwargs.get('language', 'c') + language = kwargs.get('language') + if language is None: + language = 'c' if language not in {'c', 'cpp', 'fortran'}: # OpenMPI doesn't work without any other languages return [] |
