summaryrefslogtreecommitdiff
path: root/mesonbuild/depfile.py
diff options
context:
space:
mode:
authorDylan Baker <dylan@pnwbakers.com>2022-09-07 14:59:47 -0700
committerEli Schwartz <eschwartz@archlinux.org>2022-11-30 16:23:29 -0500
commit2d349eae8cb6f1f3b61838dca7cc989e9278be28 (patch)
treebc8d6325543e0df74b16941996f07797a746a2f6 /mesonbuild/depfile.py
parent50f35039e7df321a309ee45db57d37635bf53ce3 (diff)
downloadmeson-2d349eae8cb6f1f3b61838dca7cc989e9278be28.tar.gz
pylint: enable the set_membership plugin
Which adds the `use-set-for-membership` check. It's generally faster in python to use a set with the `in` keyword, because it's a hash check instead of a linear walk, this is especially true with strings, where it's actually O(n^2), one loop over the container, and an inner loop of the strings (as string comparison works by checking that `a[n] == b[n]`, in a loop). Also, I'm tired of complaining about this in reviews, let the tools do it for me :)
Diffstat (limited to 'mesonbuild/depfile.py')
-rw-r--r--mesonbuild/depfile.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/mesonbuild/depfile.py b/mesonbuild/depfile.py
index 64b973f36..912a81732 100644
--- a/mesonbuild/depfile.py
+++ b/mesonbuild/depfile.py
@@ -36,7 +36,7 @@ def parse(lines: T.Iterable[str]) -> T.List[T.Tuple[T.List[str], T.List[str]]]:
if c in {'\\', '$'}:
escape = c
continue
- elif c in (' ', '\n'):
+ elif c in {' ', '\n'}:
if out != '':
if in_deps:
deps.append(out)