interpreter: use typed_kwargs for run_command

This also cleans up a couple of internal callers of the internal impl
version that don't set the `check` argument, and therefore trigger a
warning about not setting the check argument.

1 files changed, 4 insertions, 3 deletions

diff --git a/mesonbuild/programs.py b/mesonbuild/programs.py
index eefdc7430..192c27375 100644
--- a/mesonbuild/programs.py
+++ b/mesonbuild/programs.py
@@ -102,10 +102,11 @@ class ExternalProgram(mesonlib.HoldableObject):
 
     def get_version(self, interpreter: 'Interpreter') -> str:
         if not self.cached_version:
+            from . import build
             raw_cmd = self.get_command() + ['--version']
-            res = interpreter.run_command_impl(interpreter.current_node, (self, ['--version']), {}, True)
-            if res.returncode != 0:
-                raise mesonlib.MesonException(f'Running {raw_cmd!r} failed')
+            res = interpreter.run_command_impl(interpreter.current_node, (self, ['--version']),
+                                               {'capture': True, 'check': True, 'env': build.EnvironmentVariables()},
+                                               True)
             output = res.stdout.strip()
             if not output:
                 output = res.stderr.strip()