options: commonize code to accept unknown options

The check for unknown options is duplicated in OptionStore and MesonApp.  Place the
better version of the two as a new method of OptionStore, and use it in
OptionStore.validate_cmd_line_options.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

1 files changed, 11 insertions, 0 deletions

diff --git a/unittests/optiontests.py b/unittests/optiontests.py
index aad8eadfc..416da8f47 100644
--- a/unittests/optiontests.py
+++ b/unittests/optiontests.py
@@ -203,6 +203,17 @@ class OptionTests(unittest.TestCase):
         value = optstore.get_default_for_b_option(OptionKey('b_vscrt'))
         self.assertEqual(value, 'from_buildtype')
 
+    def test_b_nonexistent(self):
+        optstore = OptionStore(False)
+        assert optstore.accept_as_pending_option(OptionKey('b_ndebug'))
+        assert not optstore.accept_as_pending_option(OptionKey('b_whatever'))
+
+    def test_subproject_nonexistent(self):
+        optstore = OptionStore(False)
+        subprojects = {'found'}
+        assert not optstore.accept_as_pending_option(OptionKey('foo', subproject='found'), subprojects)
+        assert optstore.accept_as_pending_option(OptionKey('foo', subproject='whatisthis'), subprojects)
+
     def test_deprecated_nonstring_value(self):
         # TODO: add a lot more deprecated option tests
         optstore = OptionStore(False)