| Age | Commit message (Collapse) | Author |
|---|
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
Command line handling had almost complete annotations, but some were missing
(especially argparse related types) or wrong (the native and cross files
passed to the CmdLineFileParser).
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
Defining public API in a cross platform library is painful, especially
on Windows. Since every library have to define pretty much the same
macros, better do it in Meson.
|
|
This module is a bit of a dumping ground for code generators,
particularly ones that are important and non-trivial to wrap, either due
to multiple implementations, major command line changes, or complex
outputs (such as those that may output a directory structure).
The initially provided method is for lex. It provides a simple wrapper
that handles win_flex, reflex, flex, and generic lex.
|
|
This allows for a lot of type safety to be introduced, and almost all
casting to be removed.
|
|
This allows us to simplify running mypy, as we can just mypy the entire
utils module regardless of the platform we're using. As an added bonus,
this means we open one less module.
|
|
The majority of this is just adding annotations to convince mypy that
everything is okay. There is one place where there is a real change,
which is validating that the keyword arguments (which are unbound) are
of a valid type to be encoded as JSON.
|
|
|
|
|
|
See also https://github.com/hauntsaninja/mypy_primer/pull/77
|
|
Mostly this was just adding a few asserts for options, and one bug fix
from the option refactor
|
|
This as much as anything is to stop lying to envconfig about the
potential types it will be given.
|
|
They are very similar, but they are not exactly the same. By splitting
them we can get full type safety, and run mypy over the options.py file!
|
|
|
|
With the use of `typing_extensions.TypeAlias` we can get recursive
types, which solves most of the issues we had with this file.
|
|
|
|
Since it's an implementation detail, and shouldn't be exposed. This also
helps give better error messages when a user writes `import('qt')`,
since otherwise you get an error about `qt doesn't have an initialize
method`, and now you get `qt module doesn't exist`.
|
|
|
|
Special notes:
- _nvcc_arch_flags is always called with exact arguments, no need for
default values
- min_driver_version has its args annotation loosened because it has to
fit the constraints of the module interface?
|
|
|
|
They already are warning free
|
|
Other than one case that I think cannot be actually hit (or it would
fail).
|
|
The only backend that can return values in generate() is ninja, so this
was useless cruft.
|
|
|
|
|
|
This allows verifying that meson is type-safe under older versions of
Python, which it currently is. Different versions of Python sometimes
have different supported types for an API.
Verify this in CI.
(We flush output to ensure CI prints lines in the right order.)
|
|
|
|
|
|
|
|
This is a helper, currently only used by cargo. It could be moved later
if there are other users.
|
|
mypy might be installed with a different python than the one run_mypy.py
is using.
|
|
This reverts commit 0b7d935a846b8f2aa33b4e0d19fd7b4423d35df4.
The issue is fixed in mypy 1.0.0 now.
|
|
Useful for running as a thin wrapper in other contexts that expect the
ability to run mypy itself with arbitrary arguments.
|
|
EnvironmentVariables was always broken, it used MutableMapping because
everyone <3 abstract interfaces, especially when they are broken and
don't actually do what you want.
This needs a dict interface, exposing `.copy()`. We either use a dict or
os._Environ, and the latter also supports that.
Also fix a broken import, and the fallout from forgetting to update the
signature of self.envvars in commit b926374205bd761085031755c87152d08bc10e9d.
|
|
The base module is fully typed, but the numbered version are not, though
it's pretty trivial to do so.
|
|
|
|
mypy has a bug when running on/for 3.11 which results in incorrect
analysis of the codebase, specifically due to enum.Enum's self.name
See:
https://github.com/python/typeshed/issues/7564
https://github.com/python/mypy/issues/12483
|
|
If those files are not yet known to be typed, skip them. This makes it
possible to trivially check a shortlist of files that were just changed
and see if they regress our mypy coverage. Ideal for use in a git
pre-commit hook.
|
|
Those classes are used by wrapper scripts and we should not have to
import the rest of mesonlib, build.py, and all their dependencies for
that.
This renames mesonlib/ directory to utils/ and add a mesonlib.py module
that imports everything from utils/ to not have to change `import
mesonlib` everywhere. It allows to import utils.core without importing
the rest of mesonlib.
|
|
|
|
Thanks to `ModuleInfo`, all modules are just named `foo.py` instead of
`unstable_foo.py`, which simplifies the import method a bit. This also
allows for accurate FeatureNew/FeatureDeprecated use, as we know when
the module was added and if/when it was stabilized.
|
|
|
|
|
|
|
|
Unfortunately, checking for strings without context is exceedingly prone
to false positives, while missing anything that indirectly opens a file.
Python 3.10 has a feature to warn about this though -- and it uses a
runtime check which runs at the same time that the code fails to open
files in the broken Windows locale. Set this up automatically when
running the testsuite.
Sadly, Python's builtin feature to change the warning level, e.g. by
setting EncodingWarning to error at startup, is utterly broken if you
want to limit it to only certain modules. This is tracked in order to be
more efficiently ignored at https://bugs.python.org/issue34624 and
https://github.com/python/cpython/pull/9358
It is also very trigger happy and passing stuff around via environment
variable either messes with the testsuite, or with thirdparty programs
which are implemented in python *such as lots of gnome*, or perhaps
both.
Instead, add runtime code to meson itself, to add a hidden "feature".
In the application source code, running the 'warnings' module, you can
actually get the expected behavior that $PYTHONWARNINGS doesn't have. So
check for a magic testsuite variable every time meson starts up, and if
it does, then go ahead and initialize a warnings filter that makes
EncodingWarning fatal, but *only* when triggered via Meson and not
arbitrary subprocess scripts.
|
|
|
|
|
|
|
|
Add type annotations and typed_pos_args to the keyval module
|
