summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTamás Bálint Misius <lbphacker@gmail.com>2023-11-04 12:59:01 +0100
committerJussi Pakkanen <jpakkane@gmail.com>2023-11-20 19:25:36 +0200
commitdfd8cfbd8d9ce03473cb17a722400cb4a8d1b67e (patch)
tree7f08d7cbc63b5edc81c3261bba1e9898411dd16d
parentdea72e42bfcd25ac6e3ae55bf99e063cf5b77101 (diff)
downloadmeson-dfd8cfbd8d9ce03473cb17a722400cb4a8d1b67e.tar.gz
vs2010backend: fix incompatibility with custom manifests
EmbedManifest seems to default to true, which creates a default manifest based on other parameters (likewise defaults) and makes it impossible to supply your own with CREATEPROCESS_MANIFEST_RESOURCE_ID. There is value to being able to do this and no value to the default one, so this should be disabled.
-rw-r--r--mesonbuild/backend/vs2010backend.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/mesonbuild/backend/vs2010backend.py b/mesonbuild/backend/vs2010backend.py
index cb1ea7833..f4de65823 100644
--- a/mesonbuild/backend/vs2010backend.py
+++ b/mesonbuild/backend/vs2010backend.py
@@ -693,6 +693,8 @@ class Vs2010Backend(backends.Backend):
if target_ext:
ET.SubElement(direlem, 'TargetExt').text = target_ext
+ ET.SubElement(direlem, 'EmbedManifest').text = 'false'
+
return (root, type_config)
def gen_run_target_vcxproj(self, target: build.RunTarget, ofname: str, guid: str) -> None: